Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Theme Export: Convert spaces to tabs in theme.json #39751

Merged
merged 1 commit into from
Mar 28, 2022
Merged

Theme Export: Convert spaces to tabs in theme.json #39751

merged 1 commit into from
Mar 28, 2022

Conversation

scruffian
Copy link
Contributor

@scruffian scruffian commented Mar 25, 2022 •
edited
Loading

What?

Convert spaces to tabs when we export theme.json during a theme export.

Why?

WordPress coding standards require tabs for json files.

How?

This uses a regex to do the conversion.

Testing Instructions

  1. Switch to a theme that has a theme.json file
  2. Export the theme
  3. Check that the zip file contains a theme.json file with tabs not spaces

@WordPress/block-themers

@scruffian scruffian added the [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. label Mar 25, 2022
@scruffian scruffian self-assigned this Mar 25, 2022
@scruffian scruffian mentioned this pull request Mar 25, 2022
Merged
pbking
pbking approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@pbking pbking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find a situation where this didn't work as expected.

🚢 👍

@pbking pbking mentioned this pull request Mar 25, 2022
Closed
@scruffian scruffian force-pushed the update/theme-json-tabbed branch from ec21593 to 3542763 Compare March 28, 2022 11:30
@scruffian scruffian merged commit dc2592e into trunk Mar 28, 2022
@scruffian scruffian deleted the update/theme-json-tabbed branch March 28, 2022 13:28
@github-actions github-actions bot added this to the Gutenberg 13.0 milestone Mar 28, 2022
@adamziel adamziel mentioned this pull request Apr 4, 2022
Closed
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pbking pbking pbking approved these changes

@TimothyBJacobs TimothyBJacobs Awaiting requested review from TimothyBJacobs

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees

@scruffian scruffian

Labels
[Feature] Themes Questions or issues with incorporating or styling blocks in a theme.
Projects
None yet
Milestone
Gutenberg 13.0
Development

Successfully merging this pull request may close these issues.
2 participants
@scruffian @pbking